Workflow to check we have a paper trail on répertoire changes #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
changed the title
eggrobin
added
pipeline-provisionally-assigned
and removed
pipeline-provisionally-assigned
labels
eggrobin
changed the title
srl295
requested changes
Dec 19, 2023
Comment on lines
+31
to
+36
| sed 's/^\([^;]*;[^;]*\);.*$/\1/' merged/unicodetools/data/ucd/dev/UnicodeData.txt > merged-repertoire.txt | ||
| sed 's/^\([^;]*;[^;]*\);.*$/\1/' base/unicodetools/data/ucd/dev/UnicodeData.txt > base-repertoire.txt | ||
| if diff base-repertoire.txt merged-repertoire.txt | ||
| then echo "repertoire-changed=false" >> "$GITHUB_OUTPUT" | ||
| else echo "repertoire-changed=true" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
the 'sed' filter might be best in a local file for testing.
There was a problem hiding this comment.
Added a comment, but I don’t think there is much to gain from splitting that regex into its own file.
There was a problem hiding this comment.
could be useful on its own… not a high prio
|
looks like a good idea, with some suggestions… |
eggrobin
added
pipeline-provisionally-assigned
pipeline-16.0
and removed
pipeline-16.0
pipeline-provisionally-assigned
labels
This reverts commit 149d822.
srl295
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #626 (comment).